Edward Haas has posted comments on this change.
Change subject: utils: atomic write ......................................................................
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/61482/8/lib/vdsm/utils.py File lib/vdsm/utils.py:
Line 932: return rget(dict.get(keys[0]), keys[1:], default) Line 933: Line 934: Line 935: @contextmanager Line 936: def atomic_write(path, flag):
call it - atomic_file_write_context. and if its only write, remove the flag
Without the '_context' please, I prefer the type name not to be specified, the 'with' should be enough in the usage. Line 937: """Atomically write into a file. Line 938: Line 939: Usage: Line 940: