Nir Soffer has posted comments on this change.
Change subject: utils: Correct and faster list2cmdline ......................................................................
Patch Set 6: Verified+1
Rebase and update profiling results with current master.
Verified by the tests and by inspecting the logs and copying complext lvm commands from the log and running them in the shell.
Here is an example complex lvm command that use correct quoting now:
/usr/bin/sudo -n /usr/sbin/lvm pvs --config ' devices { preferred_names = ["^/dev/mapper/"] ignore_suspended_devices=1 write_cache_state=0 disable_after_error_count=3 obtain_device_list_from_udev=0 filter = [ '''a|/dev/mapper/1IET_00010001|/dev/mapper/1IET_00010002|/dev/mapper/1IET_00010003|/dev/mapper/1IET_00010004|/dev/mapper/1IET_00010005|/dev/mapper/1IET_00010006|/dev/mapper/1IET_00010007|/dev/mapper/1IET_00010008|/dev/mapper/1IET_00010009|/dev/mapper/1IET_0001000a|/dev/mapper/1IET_00020001|/dev/mapper/1IET_00020002|/dev/mapper/1IET_00020003|/dev/mapper/1IET_00020004|/dev/mapper/1IET_00020005|/dev/mapper/1IET_00020006|/dev/mapper/1IET_00020007|/dev/mapper/1IET_00020008|/dev/mapper/1IET_00020009|/dev/mapper/1IET_0002000a|/dev/mapper/3600144f09dbd05000000522dde040011|/dev/mapper/3600144f09dbd05000000522dde050012|/dev/mapper/3600144f09dbd05000000522dde070013|/dev/mapper/3600144f09dbd05000000522dde090014|/dev/mapper/3600144f09dbd05000000522dde0a0015|/dev/mapper/3600144f! 09dbd05000000522dde0c0016|/dev/mapper/3600144f09dbd05000000522dde0d0017|/dev/mapper/3600144f09dbd05000000522dde0f0018|/dev/mapper/3600144f09dbd05000000522dde100019|/dev/mapper/3600144f09dbd05000000522dde12001a|''', '''r|.*|''' ] } global { locking_type=1 prioritise_write_locks=1 wait_for_locks=1 use_lvmetad=0 } backup { retain_min = 50 retain_days = 0 } ' --noheadings --units b --nosuffix --separator '|' --ignoreskippedcluster -o uuid,name,size,vg_name,vg_uuid,pe_start,pe_count,pe_alloc_count,mda_count,dev_size