Liron Ar has posted comments on this change.
Change subject: introducing capability to stream data to image ......................................................................
Patch Set 10:
(2 comments)
http://gerrit.ovirt.org/#/c/23281/10/vdsm/storage/imageSharing.py File vdsm/storage/imageSharing.py:
Line 17: # Refer to the README and COPYING files for full details of the license Line 18: # Line 19: Line 20: import logging Line 21: import curlImgWrap
you've introduced new imports - please introduce them properly sorted.
Done Line 22: import signal Line 23: import socket Line 24: Line 25: import storage_exception as se
Line 101: p.stdin.write(data) Line 102: # Process stdin is not a real file object but a wrapper using Line 103: # StringIO buffer. To ensure that we don't use more memory if we Line 104: # get data faster then dd read it from the pipe, we flush on every Line 105: # write. We can remove if we can limit the buffer size used by
right. sorry for not being clear in my request.
Done Line 106: # this stdin wrapper. Line 107: p.stdin.flush() Line 108: bytes_left = bytes_left - len(data) Line 109: