Change in vdsm[master]: Properly raise OSError in betterPopen

Saggi Mizrahi has posted comments on this change.

Change subject: Properly raise OSError in betterPopen
......................................................................

Patch Set 1: (1 inline comment)

....................................................
File vdsm/betterPopen/createprocess.c
Line 288: 
Line 289:     safeClose(errnofd[1]);
Line 290:     errnofd[1] = -1;
Line 291:     if (read(errnofd[0], &childErrno, sizeof(int)) == sizeof(int)) {
Line 292:         errno = childErrno;
It's never raceful, errno is thread local.
It would have been impossible to use in a multithreaded environment otherwise
Line 293:         PyErr_SetFromErrno(PyExc_OSError);
Line 294:         goto fail;
Line 295:     }
Line 296:

--
To view, visit http://gerrit.ovirt.org/9592
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2429093229aa1f98263b1d9eb1b5557d49ce52fd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi