Vinzenz Feenstra has posted comments on this change.
Change subject: Move virt things into vdsm/virt ......................................................................
Patch Set 10:
(6 comments)
http://gerrit.ovirt.org/#/c/21792/10/vdsm.spec.in File vdsm.spec.in:
Line 933: %{_datadir}/%{vdsm_name}/tc.py* Line 934: %{_datadir}/%{vdsm_name}/vdsm Line 935: %{_datadir}/%{vdsm_name}/vdsm-restore-net-config Line 936: %{_datadir}/%{vdsm_name}/vdsm-store-net-config Line 937: %{_datadir}/%{vdsm_name}/virt/vm.py*
Please put the virt package together. Lines:
true true, and then again in this file is no order at all here Line 938: %{_datadir}/%{vdsm_name}/virt/vmexitreason.py* Line 939: %{_datadir}/%{vdsm_name}/virt/vmpowerdown.py* Line 940: Line 941: %config(noreplace) %{_sysconfdir}/%{vdsm_name}/vdsm.conf
http://gerrit.ovirt.org/#/c/21792/10/vdsm/clientIF.py File vdsm/clientIF.py:
Line 35: from virt import vm Line 36: from vdsm import constants Line 37: from vdsm import utils Line 38: import caps Line 39: from virt.vmChannels import Listener
let's use this opportunity to rename the vmChannels to vmchannles.
The follow up commit for this has been submitted as: http://gerrit.ovirt.org/26192 Line 40: from virt.vm import Vm Line 41: import blkid Line 42: import supervdsm Line 43: from virt import sampling
http://gerrit.ovirt.org/#/c/21792/10/vdsm/virt/Makefile.am File vdsm/virt/Makefile.am:
Line 1: # Line 2: # Copyright 2013 Red Hat, Inc.
2014 for now ;-)
The patch was originally done 2013, if at all we should update this to 2013-2014 Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or
http://gerrit.ovirt.org/#/c/21792/10/vdsm/virt/__init__.py File vdsm/virt/__init__.py:
Line 1
Missing copyright notice for this beautiful blank line.
Yay let's copyright all the blank files on this planet!
http://gerrit.ovirt.org/#/c/21792/10/vdsm/virt/guestIF.py File vdsm/virt/guestIF.py:
Line 25: import json Line 26: import supervdsm Line 27: import unicodedata Line 28: Line 29: import vmstatus
now that this is the virt package, this line should be
yes Line 30: Line 31: _MAX_SUPPORTED_API_VERSION = 0 Line 32: _IMPLICIT_API_VERSION_ZERO = 0 Line 33:
http://gerrit.ovirt.org/#/c/21792/10/vdsm/virt/vmChannels.py File vdsm/virt/vmChannels.py:
Line 1: # Line 2: # Copyright 2012 Red Hat, Inc.
This file has been modified after 2012 IIRC
Unrelated to this patch though, but yes Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or