Yaniv Bronhaim has posted comments on this change.
Change subject: Packaging: fix libvirt configuration
......................................................................
Patch Set 1:
(1 comment)
....................................................
Commit Message
Line 14: set to "/dev/null", but later we need to grep
"${BY_VDSM_VERS}" from
Line 15: QLCONF to confirm libvirt is configured. grep returns 1 for QLCONF but
Line 16: actually libvirt is configured. This patch does not set QLCONF to
Line 17: "/dev/null", this is harmless because when libvirt-sanlock is not
Line 18: enabled, no one reads and cares QLCONF actually.
imho, yes
Line 19:
Line 20: Change-Id: I34fa3764b999e71186171931664b0481b2ef3a15
--
To view, visit
http://gerrit.ovirt.org/20168
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I34fa3764b999e71186171931664b0481b2ef3a15
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes