Nir Soffer has posted comments on this change.
Change subject: Added standard build skeleton
......................................................................
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/41928/3/automation/check-patch.req
File automation/check-patch.req:
Line 1: yum
You can replace this with one call to yum builddep in check-patch.sh
Who wil maintain this list, and update it when the spec changes? Why should we pay for maintaining the same info twice?
Line 2: sudo
Line 3: dhclient
Line 4: autoreconf
Line 5: gettext-devel
--
To view, visit
https://gerrit.ovirt.org/41928
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I24b446d3ae38c944b5a28d56ed0965d0f2edc206
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Caro
dcaroest@redhat.com
Gerrit-Reviewer: Dan Kenigsberg
danken@redhat.com
Gerrit-Reviewer: David Caro
dcaroest@redhat.com
Gerrit-Reviewer: Eyal Edri
eedri@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
nsoffer@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim
ybronhei@redhat.com
Gerrit-Reviewer: automation@ovirt.org
Gerrit-HasComments: Yes