Zhou Zheng Sheng has posted comments on this change.
Change subject: Adding [start|stop]MonitoringDomain().
......................................................................
Patch Set 1:
(1 comment)
....................................................
File vdsm/storage/sp.py
Line 1033:
Line 1034: # If the domain that we are detaching is the master domain
Line 1035: # we attempt to stop the SPM before releasing the host id
Line 1036: if self.masterDomain.sdUUID == sdUUID:
Line 1037: self.stopSpm()
I add
self.domainMonitor.stopMonitoring(sdUUID)
to this line, then the problem mentioned on line 1551 is fixed, is this OK?
Line 1038:
Line 1039: self.updateMonitoringThreads()
Line 1040: self.log.debug("Force detach for domain `%s` is done",
sdUUID)
Line 1041:
--
To view, visit
http://gerrit.ovirt.org/19762
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Gadi Ickowicz <gickowic(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-HasComments: Yes