Ayal Baron has posted comments on this change.
Change subject: upgrade: reallocate the metadata slots when needed ......................................................................
Patch Set 6: (1 inline comment)
.................................................... File vdsm/storage/imageRepository/formatConverter.py Line 156: Line 157: if metaOffset < metaMaxSlot: Line 158: continue Line 159: Line 160: log.debug("Reallocating metadata slot %s for volume %s", I disagree. Upgrade rarely happens and when it does you want to be able to track what's going on. Moving the md is an important part of it. Even if we have a few hundred lines of this, it's no big deal. An LVM VG cannot really have many more than that anyway so this shouldn't be an issue. Line 161: metaOffset, vol.volUUID) Line 162: metaContent = vol.getMetadata() Line 163: Line 164: with vol._tagCreateLock:
-- To view, visit http://gerrit.ovirt.org/9660 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I15b6a85969a10b5e2b852031fc510aabcc2d5276 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server