Antoni Segura Puimedon has posted comments on this change.
Change subject: Bond destroying ......................................................................
Patch Set 4: (1 inline comment)
Just one very minor comment. But I think the patch can be taken even without that change.
.................................................... File lib/vdsm/tool/load_needed_modules.py.in Line 41: Line 42: Line 43: def _enable_bond_dev(): Line 44: # @ENGINENAME@ currently assumes that all bonding devices pre-exist Line 45: existing = set(file(netinfo.BONDING_MASTERS).read().split()) I know you didn't write the "file", but since you are modifying this line... could you change it to use open? file is deprecated and we should get rid of it in the whole codebase. Line 46: for bond in netinfo.REQUIRED_BONDINGS - existing: Line 47: with open(netinfo.BONDING_MASTERS, 'w') as f: Line 48: f.write('+%s\n' % bond) Line 49:
-- To view, visit http://gerrit.ovirt.org/13752 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I0cd27f1ff9a62e202c3513e54df5481d1b72ed7c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Sebek psebek@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Petr Sebek psebek@redhat.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server