Dan Kenigsberg has posted comments on this change.
Change subject: vm iface statistics: never report negative rates ......................................................................
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/24152/1/vdsm/vm.py File vdsm/vm.py:
Line 609: ifStats['txDropped'] = str(eInfo[nic.name][7]) Line 610: Line 611: ifRxBytes = (100.0 * Line 612: (eInfo[nic.name][0] - sInfo[nic.name][0]) % Line 613: 2 ** 32 /
Use constant and explain why the maximum value is 2**32. Can we get this va
You comment is correct, and I have a partial answer in http://gerrit.ovirt.org/24194 .
Since this patch is an ovirt-3.4 backport of a bug fix, would you agree to ack it, and continue the discussion on the master branch? Line 614: sampleInterval / ifSpeed / self.MBPS_TO_BPS) Line 615: ifTxBytes = (100.0 * Line 616: (eInfo[nic.name][4] - sInfo[nic.name][4]) % Line 617: 2 ** 32 /