Federico Simoncelli has posted comments on this change.
Change subject: vm: pre-validate disks for snapshot ......................................................................
Patch Set 4:
(1 comment)
.................................................... File vdsm/vm.py Line 3730: except Exception: Line 3731: self.log.error("Unable to prepare the volume path " Line 3732: "for the disk: %s", vmDevName, exc_info=True) Line 3733: # Trying to rollback (teardown) all drives Line 3734: _rollbackDrives(newDrives) it doesn't make much of a difference, but ok, let's not be cheap with variables Line 3735: return errCode['snapshotErr'] Line 3736: Line 3737: snapelem = _diskSnapshot(vmDevName, newDrives[vmDevName]["path"]) Line 3738: disks.appendChild(snapelem)