Change in vdsm[master]: network: disable IPv6 via sysctl if no IPv6 functionality wa...

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: network: disable IPv6 via sysctl if no IPv6 functionality was requested
......................................................................

Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/43252/1/vdsm/network/configurators/ifcfg.py
File vdsm/network/configurators/ifcfg.py:

Line 95:         self._addSourceRoute(bridge)
Line 96:         _ifup(bridge)
Line 97:         if not bridge.ipv6.address and not bridge.ipv6.ipv6autoconf and (
Line 98:                 not bridge.ipv6.dhcpv6):
Line 99:             # disallow IPv6 traffic on the bridge if IPv6 is not requested
the comment only translate Python into English (which is not really useful).

You could write:

# disable ipv6 (unless explictly requested) to avoid 
 # guest-host communication over ipv6

but atucally, this should go into the commit message.
Line 100:             sysctl.disable_ipv6(bridge.name)
Line 101: 
Line 102:     def configureVlan(self, vlan, **opts):
Line 103:         self.configApplier.addVlan(vlan, **opts)