Change in vdsm[master]: configfile: comment out old configuration when attribute is ...

[Code Review]

From Dan Kenigsberg <danken(a)redhat.com&gt;:

Dan Kenigsberg has submitted this change and it was merged.

Change subject: configfile: comment out old configuration when attribute is set by vdsm
......................................................................


configfile: comment out old configuration when attribute is set by vdsm

When vdsm configures a key that already exists in conf file, the new key
will be created in vdsm-config-section. oldentries is a variable that tried to
do the opposite and leave keys instead of overriding with vdsm content if the
attribute is already set - the intention should be to use vdsm configuration
after calling vdsm-tool configure. This patch comment-out fields that
vdsm adds with a comment above those comments.

Change-Id: Id1dba75449b712432e0c2bc5b128cc996ede0153
Related-To: https://bugzilla.redhat.com/917062
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
---
M lib/vdsm/tool/configfile.py
M tests/tool_test.py
2 files changed, 58 insertions(+), 16 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Yaniv Bronhaim: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/74331
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id1dba75449b712432e0c2bc5b128cc996ede0153
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com&gt;