Federico Simoncelli has posted comments on this change.
Change subject: vm: extend shared property to support locking
......................................................................
Patch Set 5:
(1 comment)
....................................................
File vdsm/vm.py
Line 1486: if not self.hasVolumeLeases:
Line 1487: return # empty items generator
Line 1488:
Line 1489: # NOTE: at the moment we are generating the lease only for the leaf
Line 1490: # when libvirt will support shared leases this will loop over all
Finish comment.
Line 1491: for volInfo in self.volumeChain[-1:]:
Line 1492: lease = XMLElement('lease')
Line 1493: lease.appendChildWithArgs('key', text=volInfo['volumeID'])
Line 1494: lease.appendChildWithArgs('lockspace',
--
To view, visit
http://gerrit.ovirt.org/17714
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9429ead45caac1178957a33393642817db59508f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli
fsimonce@redhat.com
Gerrit-Reviewer: Arik Hadas
ahadas@redhat.com
Gerrit-Reviewer: Ayal Baron
abaron@redhat.com
Gerrit-Reviewer: Eduardo
ewarszaw@redhat.com
Gerrit-Reviewer: Federico Simoncelli
fsimonce@redhat.com
Gerrit-Reviewer: Greg Padgett
gpadgett@redhat.com
Gerrit-Reviewer: Itamar Heim
iheim@redhat.com
Gerrit-Reviewer: Sandro Bonazzola
sbonazzo@redhat.com
Gerrit-Reviewer: Yeela Kaplan
ykaplan@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes