Ayal Baron has posted comments on this change.
Change subject: storage: set block schedule elevator using udev ......................................................................
Patch Set 2: (2 inline comments)
.................................................... File vdsm.spec.in Line 478: # Line 479: # Mark the existance of the rules before upgrade Line 480: # Line 481: rules="/lib/udev/rules.d/12-vdsm-elevator.rules" Line 482: if [ "$1" = 2 -a -f "${rules}" ]; then Ack on the above, I previously missed that you limit this to upgrade only. Line 483: touch "${rules}.lock" Line 484: fi Line 485: Line 486: %post
Line 515: rules="/lib/udev/rules.d/12-vdsm-elevator.rules" Line 516: if [ -f "${rules}.lock" ]; then Line 517: rm -f "${rules}.lock" Line 518: else Line 519: rm -f "${rules}" why do you keep the lock file in this case? wouldn't this cause the subsequent upgrade to install the rules? Line 520: fi Line 521: fi Line 522: Line 523: exit 0
-- To view, visit http://gerrit.ovirt.org/8700 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I0a8de1c861bf4570509599b6f47235ed38cc424d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Fabian Deutsch fabiand@fedoraproject.org Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Itamar Heim iheim@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com