Mark Wu has posted comments on this change.
Change subject: Don't monitor the usage of '/var/run/vdsm' in diskStats ......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File lib/vdsm/utils.py Line 230: A sample of host-related statistics. Line 231: Line 232: Contains the sate of the host in the time of initialization. Line 233: """ Line 234: MONITORED_PATHS = ['/tmp', '/var/log', '/var/log/core'] According to the following engine code, it looks engine go through the items in 'diskStats' reported by vdsm. That means vdsm decides the monitored paths and engine just retrieve information from it. So we don't need change the engine code
http://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=blob;f=backend/manager/m...
http://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=blob;f=backend/manager/m...
For /tmp, you're right. But it's still a normal local disk filesystem on RHEL6. So I need figure out a way to cover different platforms. Line 235: Line 236: def _getDiskStats(self): Line 237: d = {} Line 238: for p in self.MONITORED_PATHS:
-- To view, visit http://gerrit.ovirt.org/11675 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Idb0a4ae2cf7ceb6297e348d9e90c166373461ca1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server