Dan Kenigsberg has posted comments on this change.
Change subject: tests: add simple balloon functional testcase
......................................................................
Patch Set 11: Code-Review-1
(1 comment)
Marking -1 until the mom issue is understood.
http://gerrit.ovirt.org/#/c/12820/11/tests/functional/vmQoSTests.py
File tests/functional/vmQoSTests.py:
Line 27: from utils import VdsProxy, SUCCESS
Line 28:
Line 29:
Line 30: def setUpModule():
Line 31: # to make pyflakes happy
I find this comment confusing... this function is here for explicitness, not just to make
pyflakes happy!
Line 32: virtTests.setUpModule()
Line 33:
Line 34:
Line 35: def tearDownModule():
--
To view, visit
http://gerrit.ovirt.org/12820
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8140fe1c754d9d4026c503a19420e6552a3f4fe
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes