Yaniv Bronhaim has posted comments on this change.
Change subject: ssl: runtime config to choose implementation ......................................................................
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/44689/9/lib/vdsm/sslcompat.py File lib/vdsm/sslcompat.py:
Line 29: from . import m2cutils as sslutils Line 30: from .m2cutils import SSLSocket Line 31: from .m2cutils import SSLHandshakeDispatcher Line 32: _USED_M2C = True Line 33: except ImportError:
Sure, This approach was to solve this particular issue. If we can use vdsm_
use m2crypto as default and add a check in vdsm/vdsm that if we run over debian and the config to use ssl is not exist there, exit with an error that suggest the user to configure the ssl value - "add to vdsm.conf ssl_implementation=ssl" - I don't think we need to add it for the user by vdsm-tool. Line 34: _log.warning('Configured m2crypto but not available falling back' Line 35: ' to ssl') Line 36: else: Line 37: # we need it to satisfy pyflakes