Nir Soffer has posted comments on this change.
Change subject: tests: Add a live merge functional test
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.ovirt.org/#/c/29824/1/tests/functional/virtTests.py
File tests/functional/virtTests.py:
Line 240:
Line 241: @requireKVM
Line 242: @permutations([['localfs'], ['iscsi'], ['nfs']])
Line 243: def testVmWithStorage(self, backendType):
Line 244: disk = storageTests.StorageTest()
why is a StorageTest instance called a "disk"?
Yea,
this is a bit extreme. The common part should move to utils instead of reusing a test.
Line 245: disk.setUp()
Line 246: conf = storageTests.storageLayouts[backendType]
Line 247: drives = disk.generateDriveConf(conf)
Line 248: customization = {'vmId':
'88888888-eeee-ffff-aaaa-111111111111',
Line 552: jobId)
Line 553: jobIds.append(jobId)
Line 554: self._waitBlockJobs(vmId, jobIds)
Line 555: actual = self._getVolumeChains(vmId)
Line 556: self.assertEquals(chains, actual)
Looks like you assert that VDSM reports the result you expect. If
this is t
The chance that you can sneak into the machines running this test and
install your fake vdsm is quite small :-)
--
To view, visit
http://gerrit.ovirt.org/29824
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd5a2f7eedaef9e90981256de66fc3ed21658e89
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yoav Kleinberger <ykleinbe(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes