Dan Kenigsberg has submitted this change and it was merged.
Change subject: Avoid skipping libvirt when add bridgeless network
......................................................................
Avoid skipping libvirt when add bridgeless network
Change since V2
- Adjust subject and comment to make it more reasonable.
Change since V1
- Move this validation into _addNetworkValidation based
on Dan's suggestion.
The bridgeless network can not be added when the options contain
skip libvirt. When I dig into the code, seems this type of network
is supported by libvirt, but it will not do its real job if skip
libvirt based on current logical in addNetwork. So set limitation
to avoid such situation.
Change-Id: Ia61fab631e8eecf3dc698a94d72858d7a72ade08
Signed-off-by: Lei Li <lilei(a)linux.vnet.ibm.com>
---
M vdsm/configNetwork.py
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Shahar Havivi: Looks good to me, but someone else must approve
Dan Kenigsberg: Verified; Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/3919
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia61fab631e8eecf3dc698a94d72858d7a72ade08
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lei Li <lilei(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Lei Li <lilei(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>