Piotr Kliczewski has posted comments on this change.
Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................
Patch Set 30: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/17644/30/vdsm/gluster/apiwrapper.py
File vdsm/gluster/apiwrapper.py:
Line 274: return self._gluster.geoRepMountBrokerSetup(remoteUserName,
Line 275: remoteGroupName,
Line 276: remoteVolumeName)
Line 277:
Line 278: def geoRepSessionCreate(self, volumeName, remoteHost, remotVolumeName,
if you want to have options parameter in apiwrapper you need to add it to schema.
Line 279: remoteUserName=None, force=False, options=None):
Line 280: return self._gluster.volumeGeoRepSessionCreate(
Line 281: volumeName,
Line 282: remoteHost,
Line 284: remoteUserName,
Line 285: force
Line 286: )
Line 287:
Line 288: def geoRepSessionDelete(self, volumeName, remoteHost,
as above.
Line 289: remoteVolumeName,
Line 290: remoteUserName=None, options=None):
Line 291: return self._gluster.volumeGeoRepSessionDelete(
Line 292: volumeName,
--
To view, visit
https://gerrit.ovirt.org/17644
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If8c979a89ce11a1622819c474b59dcf088733594
Gerrit-PatchSet: 30
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes