Nir Soffer has posted comments on this change.
Change subject: sp: fix spm start when failing to produce domain ......................................................................
Patch Set 1:
(3 comments)
The commit message needs more love.
http://gerrit.ovirt.org/#/c/25424/1//COMMIT_MSG Commit Message:
Line 3: AuthorDate: 2014-03-05 15:25:56 +0200 Line 4: Commit: Liron Aravot laravot@redhat.com Line 5: CommitDate: 2014-03-05 15:56:21 +0200 Line 6: Line 7: sp: fix spm start when failing to produce domain fix -> Fix
when failing to produce domain -> when failing to update domain role
If you want to handle only produce errors, you should put the try-except around that line only. Line 8: Line 9: During spmStart we attept to go over all the domains and set their role Line 10: to be regular in case it's not to avoid situation in which there are two Line 11: domains with the master role.
Line 5: CommitDate: 2014-03-05 15:56:21 +0200 Line 6: Line 7: sp: fix spm start when failing to produce domain Line 8: Line 9: During spmStart we attept to go over all the domains and set their role attept -> attempt Line 10: to be regular in case it's not to avoid situation in which there are two Line 11: domains with the master role. Line 12: If we fail to produce any of the domains (which might happen, the Line 13: domains returned by getDomains(activeOnly=True) are all the domains that
Line 7: sp: fix spm start when failing to produce domain Line 8: Line 9: During spmStart we attept to go over all the domains and set their role Line 10: to be regular in case it's not to avoid situation in which there are two Line 11: domains with the master role. Empty line between paragraphs makes it easier to read. If this should be one paragraph, do not break the line. Line 12: If we fail to produce any of the domains (which might happen, the Line 13: domains returned by getDomains(activeOnly=True) are all the domains that Line 14: are are marked as active in the metadata, but it doesn't mean that they Line 15: are actually reachable and that calling produce() for the domain won't fail.