ShaoHe Feng has posted comments on this change.
Change subject: dump the core of a domain
......................................................................
Patch Set 1:
Zhou Zheng Sheng
two considerations.
1. dump file path
I think Engine has better support an data domain for dump file.
it can be nfs or others.
2. Dump is time consuming, the server does not return until finishes the dump. Can we
leverage the vdsm/storage/task.py to do asynchronous dump?
for VIR_DUMP_MEMORY_ONLY it is synchronous dump. it will blocked until the qemu-kvm
finished this dump memory.
but the default dump is asynchronous.
it is a good way to consider vdsm/storage/task.py.
actually this dumo file is generated by migration. if I can also make this VDSM API
coreDump as synchronous dump . which is same with run attribute of MigrationMonitorThread
class in vdsm/libvirtvm.py. but I think it is not a good way to support synchronous
remote call for xmlrpc. so should I support another command in order to query the process
of this dump?
--
To view, visit
http://gerrit.ovirt.org/7329
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If4aac9e747dc7aa64a6ff5ef256a7a4375aa2bb5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server