Shahar Havivi has posted comments on this change.
Change subject: add/del network - add bridgesless network ......................................................................
Patch Set 2: (3 inline comments)
.................................................... File vdsm/configNetwork.py Line 240: open(conffile, 'w').write("""DEVICE=%s.%s\nONBOOT=yes\nVLAN=yes\nBOOTPROTO=none\nBRIDGE=%s\n""" % (pipes.quote(iface), vlanId, pipes.quote(network))) 1. as you can see all the vdsm code in this module are at this format, I add my change as this module to be compatible with the rest of the code, look at the diff... 2. the same as #1
Line 505: <bridge name='%s'/></network>''' % (netName, network) Done
Line 553: bridged = False Done
-- To view, visit http://gerrit.ovirt.org/848 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Id7a3efea92312ac628e0373a5c29fbb1669058f4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shavivi@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Shahar Havivi shavivi@redhat.com