From Dan Kenigsberg danken@redhat.com:
Dan Kenigsberg has posted comments on this change.
Change subject: network: add special treatment for dpdk ports ......................................................................
Patch Set 14: Code-Review-1
(2 comments)
minor nits
https://gerrit.ovirt.org/#/c/74079/14/lib/vdsm/network/link/dpdk.py File lib/vdsm/network/link/dpdk.py:
Line 75: Line 76: return False Line 77: Line 78: Line 79: def speed(dev_name): it's kinda-obvious, but please add a TODO about what each function should be doing. Line 80: return 0 Line 81: Line 82: Line 83: def operstate(dev_name):
https://gerrit.ovirt.org/#/c/74079/14/lib/vdsm/network/link/iface.py File lib/vdsm/network/link/iface.py:
Line 41: :param oper_blocking: Block until the link is operational. Line 42: admin state is at kernel level, while link state is at driver level. Line 43: """ Line 44: if dpdk.is_dpdk(dev): Line 45: dpdk.up(dev) just like in down() below, return dpdk.up() is the right thing to do here. We simply delegate the task to dpdk, doing nothing here. Line 46: elif admin_blocking: Line 47: _up_blocking(dev, oper_blocking) Line 48: else: Line 49: ipwrapper.linkSet(dev, [STATE_UP])