Adam Litke has posted comments on this change.
Change subject: (Schema) Minor corrections for IscsiPortal ......................................................................
Patch Set 1: (1 inline comment)
.................................................... File vdsm_api/vdsmapi-schema.json Line 2291: {'type': 'IscsiPortal', 'data': {'host': 'str', '*port': 'uint16'}} So far we haven't been differentiating between integer sizes. Instead the schema tries to stick to JSON-like types. I can see the merits of specifying the integer size though. I guess this raises a broader question, do we want to use JSON types in the schema or more specific vala types?
-- To view, visit http://gerrit.ovirt.org/6844 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I92b4a49190fddb2c04989787f7468b15bff0f0ef Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com