Federico Simoncelli has posted comments on this change.
Change subject: vdsm: add support for hostdev passthrough
......................................................................
Patch Set 6:
(2 comments)
http://gerrit.ovirt.org/#/c/22462/6/tests/functional/virtTests.py
File tests/functional/virtTests.py:
Line 195: self.assertTrue('hostDevices' in stats,
Line 196: 'Host devices are not reported in
vdsCapabilities!')
Line 197: # element 0 should be 'computer' - this device should not cause
Line 198: # any security concerns and works without iommu support
Line 199: hostdev = stats['hostDevices'][0]
On my machine the first device is not "computer", I think you just should use a
static string here "computer".
Line 200: hostdev['type'] = 'hostdev'
Line 201:
Line 202: customization = {'vmId':
'77777777-ffff-3333-bbbb-222222222222',
Line 203: 'vmName': 'testVmWithHostdev',
'devices':
http://gerrit.ovirt.org/#/c/22462/6/vdsm/vm.py
File vdsm/vm.py:
Line 2896: if drive.transientDisk:
Line 2897: return True
Line 2898: return False
Line 2899:
Line 2900: def migrate(self, params):
What about live migration? Is it supported with host devices attached? I am fine if we
want to rely on libvirt for failures but could you test what is actually happening and if
we need to catch any special failure? Please also add your findings in the commit
message.
Line 2901: self._acquireCpuLockWithTimeout()
Line 2902: try:
Line 2903: if self.isMigrating():
Line 2904: self.log.warning('vm already migrating')
--
To view, visit
http://gerrit.ovirt.org/22462
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I363d2622d72ca2db75f60032fe0892c348bab121
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes