Change in vdsm[master]: profile: Add couple of tests
Francesco Romani has posted comments on this change.
Change subject: profile: Add couple of tests
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
there is a couple of typos, but not enough to downvote or require a new patchset. Good for
me.
http://gerrit.ovirt.org/#/c/27328/2/tests/profileTests.py
File tests/profileTests.py:
Line 65: @MonkeyPatch(profile, '_FORMAT', 'pstat')
Line 66: def test_pstats_format(self):
Line 67: requires_yappi()
Line 68: profile.start()
Line 69: profile.is_running() # Let if profile somthing
typo (somEthing)
Line 70: profile.stop()
Line 71: pstats.Stats(FILENAME)
Line 72:
Line 73: @MonkeyPatch(profile, 'config', make_config(enable='true'))
Line 93: profile.stop()
Line 94: self.assertFalse(profile.is_running())
Line 95:
Line 96: @MonkeyPatch(profile, 'config', make_config(enable='true'))
Line 97: def test_is_enbaled(self):
typo (enABled)
Line 98: requires_yappi()
Line 99: self.assertTrue(profile.is_enabled())
Line 100:
Line 101: # This must succeed even if yappi is not installed
--
To view, visit http://gerrit.ovirt.org/27328
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0dedc21993972ec25881f46f0b365445ed494aac
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes