Dan Kenigsberg has posted comments on this change.
Change subject: vdsm.spec: update python-pthreading ......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
I believe you've dropped the requirement for el6/7.
.................................................... File vdsm.spec.in Line 92: Requires: ntp Line 93: Requires: iproute Line 94: Requires: python-ethtool >= 0.6-3 Line 95: Requires: rpm-python Line 96: Requires: nfs-utils I think you could keep the requirement here, so it affects el6/7 builds as well, and avoid adding it for f<=18. Line 97: Requires: m2crypto Line 98: Requires: %{name}-xmlrpc = %{version}-%{release} Line 99: Line 100: %ifarch x86_64
-- To view, visit http://gerrit.ovirt.org/15395 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie50a5b7a794b9df135478f3adace7501893d992c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server