Change in vdsm[master]: tests: add HostStatsThread._getCpuCoreStats test

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: tests: add HostStatsThread._getCpuCoreStats test
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/41372/2/tests/samplingTests.py
File tests/samplingTests.py:

Line 276:         node_id, cpu_id = 0, 0
Line 277:         self._hs = sampling.HostStatsThread(self.log)
Line 278:         cpu_sample = {'user': 1.0, 'sys': 2.0}
Line 279: 
Line 280:         for fake_ts in xrange(5):  # FIXME
please use

  six.range()

in new code.

Please put a comment that is meaningful to others; I understand that you mean

 # "5" is the side of the SampleWindow
Line 281:             self._hs._samples.append(
Line 282:                 fake.HostSample(fake_ts, {cpu_id: cpu_sample}))
Line 283: 
Line 284:         def fakeNumaTopology():


-- 
To view, visit https://gerrit.ovirt.org/41372
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c6a82c77054e76d7d08322ad83d086302c2bbad
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes