Yaniv Bronhaim has posted comments on this change.
Change subject: change of the isRunning function ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
please read my comment about the timestamp usage
.................................................... File vdsm/supervdsm.py Line 131 Line 132 Line 133 Line 134 Line 135 the reason for the timestamp file was to verify that if pid of old svdsm still exist, we want to be sure that no other process got this pid after svdsm died, and it's actually the old instance that we kill.
Otherwise we might kill another process that got this pid after svdsm died.
-- To view, visit http://gerrit.ovirt.org/10236 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib25809d4416f26bc95dc72e7b32b8b2a17a71879 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server