Saggi Mizrahi has posted comments on this change.
Change subject: Add hotPlug/hotUnplug disk feature
......................................................................
Patch Set 3: Looks good to me, but someone else must approve
(3 inline comments)
Just fix spacing issues if you get -1 from someone else
....................................................
File vdsm/libvirtvm.py
Line 1281: diskParams = params.get('drive')
Use [] so we get KeyError 'drive'
instead of
NoneType has not attribute __getitem__
Line 1284: self._normalizeVdsmImg(diskParams)
Space line
Line 1288: driveXml = drive.getXML().toprettyxml(encoding='utf-8')
Double space
--
To view, visit
http://gerrit.ovirt.org/1108
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iecab9e28b2e77cfeedc3b9068095f7d117eb6221
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>