Dan Kenigsberg has posted comments on this change.
Change subject: vdsm-reg: eliminate the VDSMBRIDGE macro ......................................................................
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/24814/1/vdsm_reg/deployUtil.py.in File vdsm_reg/deployUtil.py.in:
Line 85: ERR_NO_ROUTE = 7 Line 86: SCRIPT_NAME_ADD = "addNetwork" Line 87: SCRIPT_NAME_DEL = "delNetwork" Line 88: IFACE_CONFIG = "/etc/sysconfig/network-scripts/ifcfg-" Line 89: MGT_BRIDGE_NAME = "ovirtmgmt"
Will this variable be changed by a downstream patch? It makes sense to do s
yes. It would keep the downstream patch more localized to the legacy code than now (when it patches configure.ac) Line 90: REMOTE_SSH_KEY_FILE = ('/engine.ssh.key.txt',) Line 91: CORE_DUMP_PATH = '/var/lib/vdsm/core' Line 92: CORE_PATTERN = '/proc/sys/kernel/core_pattern' Line 93: XML_QUOTES = {