Change in vdsm[master]: virt: enable libgfapi
Nir Soffer has posted comments on this change.
Change subject: virt: enable libgfapi
......................................................................
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/44061/4/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 325: drive['protocol'] = volinfo['protocol']
Line 326: if drive.get('hosts') is None:
Line 327: hosts = [dict(name=volinfo['hosts'][0],
Line 328: port=volinfo['port'],
Line 329: transport=volinfo['transport'])]
Please prepare this in glusterVolume.vmVolumeInfo(), not here, so
here we h
Correction, we should take here only the first host, since libvirt does
not support mutiple hosts, so the code should be:
drive['hosts'] = [res['hosts'][0]]
And we should have a comment why we do this, and a link to the libvirt bug.
Line 330: drive['hosts'] = hosts
Line 331:
Line 332: # GUID drive format
Line 333: elif "GUID" in drive:
--
To view, visit https://gerrit.ovirt.org/44061
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I54b81e87b959b0b49c0f06810f88410e7c75de1d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes