Change in vdsm[master]: Related to 726960 - Restore higher version check.

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Related to 726960 - Restore higher version check.
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(2 inline comments)

....................................................
Commit Message
Line 7: Related to 726960 - Restore higher version check.
Please explain why this is done: "we formerly failed migrateMaster if masterVersion
arg was lower than the MD one. This semantic was broken by commit XXXX, and we would like
like to restore it, particularly in beta time"

....................................................
File vdsm/storage/sp.py
Line 631:             #TODO: is this check irrelevant?
I like to breathe after #.

--
To view, visit http://gerrit.usersys.redhat.com/927
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c7258361589fac7dc94361b88cabdf73cf48a83
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;