Liron Aravot has posted comments on this change.
Change subject: hsm: prepareForShutdown - operations order ......................................................................
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/36162/4/vdsm/storage/hsm.py File vdsm/storage/hsm.py:
Line 3452: self.log.warning("Failed to stop RepoStats thread", Line 3453: exc_info=True) Line 3454: Line 3455: self.taskMng.prepareForShutdown() Line 3456: sp.StoragePool.cleanupMasterMount()
This may never run or vdsm may be killed in the middle.
So what do you suggest? the current situation is problematic as well...it's either to replace the order or to pass on the tasks status update as it needs that mount. Line 3457: except: Line 3458: pass Line 3459: Line 3460: @classmethod