Michal Skrivanek has posted comments on this change.
Change subject: [WIP]add simple balloon functional testcase
......................................................................
Patch Set 2:
(1 comment)
....................................................
File tests/functional/xmlrpcTests.py
Line 190:
Line 191: with RollbackContext() as rollback:
Line 192: self._runVMKernelBootTemplate(rollback, customization)
Line 193: self._enableBalloonPolicy(policy, rollback)
Line 194: time.sleep(12) # MOM policy engine wake up evey 10s
*every
Also, can't we do without excessive sleeps in tests? This slows down the test
significantly and increases the likelihood people will just skip them. There are already 2
long sleeps in momTests so it's already bad. Can't we change the interval when
KSM/MOM kicks in for tests?
Line 195: balloonInf = self.s.getVmStats(
Line 196:
customization['vmId'])['statsList'][0]['balloonInfo']
Line 197: self.assertEqual(balloonInf['balloon_cur'], 0)
Line 198:
--
To view, visit
http://gerrit.ovirt.org/12820
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8140fe1c754d9d4026c503a19420e6552a3f4fe
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes