Ayal Baron has posted comments on this change.
Change subject: add/del network - add bridgesless network ......................................................................
Patch Set 8: (11 inline comments)
.................................................... File vdsm/API.py Line 1086: options['bridged'] = bridged options['bridged'] = util.tobool(bridged)
(I'm not sure if this should be done here or in the bindings)
Line 1101: options['bridged'] = bridged options['bridged'] = util.tobool(bridged)
.................................................... File vdsm/clientIF.py Line 118: configNetwork.createLibvirtNetwork(network, True, None) it would be easier on the eye if you pass the vars as kwargs (e.g. bridged=True, whatever=None)
.................................................... File vdsm_cli/vdsClient.py Line 1391: bridge = params.get('bridge', '') why didn't you change the name here to network as you did in the implementation? 'bridge' here is misleading
.................................................... File vdsm/configNetwork.py Line 264: if _isTrue(bridged): addVlan should be called with bridged as boolean, not string. so just need to be: "if bridged:"
Line 508: if _isTrue(bridged): This is a private method that should be called with bridged as boolean not string, so just needs to be: "if bridged:"
Line 583: skipLibvirt = _isTrue(options.get('skipLibvirt', False)) skipLibvirt should also be boolean at this point
Line 591: _addNetworkValidation(_netinfo, bridge=network if _isTrue(bridged) else None, vlan=vlan, bonding=bonding, nics=nics, same for bridged
Line 614: if _isTrue(bridged): same
Line 626: if not bonding and _isTrue(bridged): same
.................................................... File vdsm/netinfo.py Line 57: def bridgeless(): shouldn't this be 'getNetsByPrefix' or something? and accept prefix as param so then it would be generic? i.e. something like: def getNetsByPrefix(netPrefix): ... if name.startswith(netPrefix): ...
-- To view, visit http://gerrit.ovirt.org/848 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Id7a3efea92312ac628e0373a5c29fbb1669058f4 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shavivi@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Shahar Havivi shavivi@redhat.com