Dan Kenigsberg has posted comments on this change.
Change subject: setupNetworks: Fix incorrect mtu overriding when adding multiple networks ......................................................................
Patch Set 2: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/25343/2/tests/functional/networkTests.py File tests/functional/networkTests.py:
Line 253: '%s found unexpectedly in running config' % vlanName) Line 254: Line 255: def assertMtu(self, mtu, *elems): Line 256: for elem in elems: Line 257: self.assertEquals(int(mtu), int(self.vdsm_net.getMtu(elem))) coercing the test-based mtu into int is dependable, but Vdsm returns a non-int MTU, we'd better explode. Line 258: Line 259: @cleanupNet Line 260: @permutations([[True], [False]]) Line 261: @RequireDummyMod