Francesco Romani has posted comments on this change.
Change subject: vdsm: add support for hostdev passthrough
......................................................................
Patch Set 7:
(4 comments)
very partial and very initial review
http://gerrit.ovirt.org/#/c/22462/7/tests/functional/virtTests.py
File tests/functional/virtTests.py:
Line 208: 'vmName': 'testVmWithHostdev',
'devices':
Line 209: [hostdev]}
Line 210:
Line 211: with RunningVm(self.vdsm, customization) as vm:
Line 212: self._waitForStartup(vm, 10)
I would use targetUptime=10 just as clarification what's 10 is
about.
I agree with Douglas here.
Line 213:
Line 214: status, msg, stats = self.vdsm.getVmList(vm)
Line 215: self.assertEqual(status, SUCCESS, msg)
Line 216: exists = False
http://gerrit.ovirt.org/#/c/22462/7/vdsm/caps.py
File vdsm/caps.py:
Line 313:
Line 314: return dict(release=release, version=version, name=osname)
Line 315:
Line 316:
Line 317: def hostdevList():
Probably better to have a name starting with a verb, like the ubiquitous `get' or
`find' or something like it.
Line 318: devices = []
Line 319: for device in libvirtconnection.get().listAllDevices():
Line 320: devXML = minidom.parseString(device.XMLDesc())
Line 321: dev = {}
http://gerrit.ovirt.org/#/c/22462/7/vdsm_api/vdsmapi-schema.json
File vdsm_api/vdsmapi-schema.json:
Line 2917: # @vendor: Name of the device as reported by libvirt
Line 2918: #
Line 2919: # @product: Product of the device as reported by libvirt
Line 2920: #
Line 2921: # Since: 4.14.0
Bump to 4.15
Line 2922: ##
Line 2923: {'type': 'HostDevice',
Line 2924: 'data': {'name': 'str', 'vendor':
'str', 'product': 'str'}}
Line 2925:
Line 2931: # @deviceType: The device type (always @hostdev)
Line 2932: #
Line 2933: # @name: The name (pci_xxxx_xx_xx_x) of host's device
Line 2934: #
Line 2935: # Since: 4.14.0
ditto
Line 2936: ##
Line 2937: {'type': 'VmHostDevice',
Line 2938: 'data': {'deviceType': 'VmDeviceType', 'name':
'str'}}
Line 2939:
--
To view, visit
http://gerrit.ovirt.org/22462
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I363d2622d72ca2db75f60032fe0892c348bab121
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes