Nir Soffer has posted comments on this change.
Change subject: lvm: Update hsm.__processVGInfos() with lvm.getPV() new API
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/38421/1/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line 3003: try:
Line 3004: pvInfo = lvm.getPV(pv)
Line 3005: except se.InaccessiblePhysDev:
Line 3006: self.log.error("PV %s no longer exists", pv)
Line 3007: continue
Does this mean that now getVGInfo and getVGList may silently return
incompl
Previously the entire request was failing with AttributeError, now the
request will return the available pvs.
It would be nice if we can return info about missing pvs, but it is not the scope of this
patch.
lvm.getPV() could return a missing pv in this case, or we can add MissingPV namedduple for
feeding __fillPVDict()
Line 3008: vgInfo['pvlist'].append(self.__fillPVDict(dev, pvInfo,
vgType))
Line 3009:
Line 3010: if vgType == multipath.DEV_FCP:
Line 3011: vgType = sd.FCP_DOMAIN
--
To view, visit
https://gerrit.ovirt.org/38421
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I583c0493093d2c9c8bca8713df8ee123c415de7f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Candace Sheremeta <cshereme(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes