Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm-tool: vdsm-id: add force option to force generate id
......................................................................
Patch Set 4:
(2 comments)
....................................................
File lib/vdsm/tool/vdsm-id.py
Line 30: def getUUID():
Line 31: """
Line 32: Printing host uuid
Line 33: """
Line 34: parser = argparse.ArgumentParser('vdsm-tool configure')
vdsm-tool vdsm-id
Line 35: parser.add_argument(
Line 36: '--force',
Line 37: dest='force',
Line 38: default=False,
....................................................
File lib/vdsm/utils.py
Line 612: with open(constants.P_VDSM_NODE_ID) as f:
Line 613: __hostUUID = f.readline().replace("\n", "")
Line 614: else:
Line 615: p = subprocess.Popen([constants.EXT_SUDO,
Line 616: constants.EXT_DMIDECODE, "-s",
guess the reason for it raised for ppc usage that doesn't contain dmidecode outputs,
so why not providing proper specific solution for each arch instead of adding such hack?
otherwise why wouldn't it fail?
Line 617: "system-uuid"],
Line 618: close_fds=True, stdin=subprocess.PIPE,
Line 619: stdout=subprocess.PIPE,
Line 620: stderr=subprocess.PIPE)
--
To view, visit
http://gerrit.ovirt.org/20808
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I89f1e29c9cdad0cadb32545fa27c1702ad2e116a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes