Ido Barkan has posted comments on this change.
Change subject: hooks: ovs: better rollback ......................................................................
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/46907/11/vdsm_hooks/ovs/ovs_before_network_setu... File vdsm_hooks/ovs/ovs_before_network_setup.py:
Line 146: ovs_nets, non_ovs_nets, ovs_bonds, non_ovs_bonds = \ Line 147: _separate_ovs_nets_bonds(networks, bondings, running_config) Line 148: _configure(ovs_nets, ovs_bonds, running_config) Line 149: setup_nets_config['request']['bondings'] = non_ovs_bonds Line 150: setup_nets_config['request']['networks'] = non_ovs_nets
I dont understand. Do you mean to separate _seaparate_ovs_nets_bonds functi
I meant doing this dictionary update (which you do twice) in a function with a meaningful name. Line 151: hooking.log('Hook finished, returning non-OVS networks and bondings ' Line 152: 'back to VDSM: %s' % setup_nets_config) Line 153: Line 154: hooking.write_json(setup_nets_config)