Milan Zamazal has posted comments on this change.
Change subject: virt: Distinguish between switching to and entering post-copy migration ......................................................................
Patch Set 7:
(2 comments)
Thank you for the suggestion, I'll do it this way.
https://gerrit.ovirt.org/#/c/64143/7//COMMIT_MSG Commit Message:
Line 15: request phase and the post-copy switch phase. For instance, we should Line 16: block canceling migrations very early to avoid timing issues and Line 17: possibly canceling a post-copy migration. On the other hand we should Line 18: report a true VM state to Engine, so we can report post-copy only after Line 19: the VM actually enters it.
do we need two separate variables or can we turn the boolean in one state a
Good idea. I came to a similar conclusion when thinking about some subtleties of the preceding (cancel migration) patch. I'll probably introduce 4 states: none, initiated (just before calling libvirt to switch), requested (after a *successful* libvirt call), running (after confirming libvirt event). Line 20: Line 21: Change-Id: I88dddeab84a609ebd3d5d9139724adff9cdb1352 Line 22: Signed-off-by: Milan Zamazal mzamazal@redhat.com
https://gerrit.ovirt.org/#/c/64143/7/vdsm/virt/migration.py File vdsm/virt/migration.py:
PS7, Line 811: if ret >= 0: : self._post_copy_initiated = True
not related to this patch, but I realized just now.
Yes, you're right, thanks for pointing this out.