Dan Kenigsberg has submitted this change and it was merged.
Change subject: Refactor mom init error flow ......................................................................
Refactor mom init error flow
Splitting a log to to log invocation is bad because it could potentially separate the 2 log lines. Further more, it usually points out to a bad flow if you only sometimes need to log in the same flow so you resort to such tricks.
- Add proper exception when MomThread fails to initialize - Make the two error flows clear and have each logged properly
Change-Id: I03ff6057cdbb22b88ed2b5766bda399651c4d058 Signed-off-by: Saggi Mizrahi smizrahi@redhat.com --- M vdsm/clientIF.py M vdsm/momIF.py 2 files changed, 25 insertions(+), 10 deletions(-)
Approvals: Adam Litke: Looks good to me, but someone else must approve Doron Fediuck: Looks good to me, but someone else must approve Dan Kenigsberg: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/9481 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I03ff6057cdbb22b88ed2b5766bda399651c4d058 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server