Vinzenz Feenstra has posted comments on this change.
Change subject: execCmd: no need to pass the default sudo=False value ......................................................................
Patch Set 2: Code-Review-1
(3 comments)
http://gerrit.ovirt.org/#/c/24145/2/vdsm/storage/blockSD.py File vdsm/storage/blockSD.py:
Line 217: ioclass This can be two lines now instead of three
http://gerrit.ovirt.org/#/c/24145/2/vdsm/storage/clusterlock.py File vdsm/storage/clusterlock.py:
Line 64: Line 65: def initLock(self): Line 66: lockUtil = os.path.join(self.lockUtilPath, "safelease") Line 67: initCommand = [lockUtil, "release", "-f", self._leasesPath, "0"] Line 68: rc, out, err = misc.execCmd(initCommand, Fits into one line now Line 69: cwd=self.lockUtilPath) Line 70: if rc != 0: Line 71: self.log.warn("could not initialise spm lease (%s): %s", rc, out) Line 72: raise se.ClusterLockInitError()
http://gerrit.ovirt.org/#/c/24145/2/vdsm/storage/volume.py File vdsm/storage/volume.py:
Line 1032: # can also accept size in M or G with appropriate suffix Line 1033: # +1 is so that odd numbers will round upwards. Line 1034: cmd += [volume, "%uK" % ((size + 1) / 2)] Line 1035: Line 1036: (rc, out, err) = misc.execCmd(cmd, cwd=cwd, Fits into one line now Line 1037: deathSignal=signal.SIGKILL) Line 1038: if rc: Line 1039: raise se.VolumeCreationError(out) Line 1040: return True