Hans De Goede has posted comments on this change.
Change subject: libvirtvm.py: Refactor device xml generation ......................................................................
Patch Set 2: Verified
(1 inline comment)
Tested and works for me.
.................................................... File vdsm/libvirtvm.py Line 838: if not hasattr(self, attrName): OTOH I prefer these kind of checks to use a continue mode of operation, so as to avoid deep indentation levels.
-- To view, visit http://gerrit.ovirt.org/4132 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ic2e1c5a2d0998af38fa80d53975b0e528b9257a6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hans De Goede hdegoede@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Hans De Goede hdegoede@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com