Hans De Goede has posted comments on this change.
Change subject: libvirtvm.py: Extend controller support to allow configuring USB controllers ......................................................................
Patch Set 3:
Correct, the engine would need to provide a master dict, with a startport entry in there.
As for the engine not being able to handle this, this is following the same structure as the already existing address support is.
More importantly it closely mirrors the libvirt-xml structure. Now that RHEV is using libvirt for all newer versions, I don't think it makes sense to put a lot of translation between the xmlrpc contents for vm configuration and the libvirt xml.
The closer the 2 are together, the easier it will be to extend vdsm to support new devices supported by libvirt. As shown by how little code this patch changes.
IOW I believe the engine should adapt to generate xmlrpc calls with parameters closely matching the libvirt-xml syntax. The engine needs to be modified anyways whenever new devices need to be supported. Why then not make these changes in such a way that no translation needs to be done by vdsm, eliminating a possible source of errors?
-- To view, visit http://gerrit.ovirt.org/4095 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If4fd6bed73cfa67fd6b29d3c352aebc7c25cff5f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hans De Goede hdegoede@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eli Mesika emesika@redhat.com Gerrit-Reviewer: Hans De Goede hdegoede@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Omer Frenkel ofrenkel@redhat.com