Liron Ar has posted comments on this change.
Change subject: sp: fix spm start when failing to produce domain ......................................................................
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/25424/2/vdsm/storage/sp.py File vdsm/storage/sp.py:
Line 209: Line 210: self._backend.setDomainRegularRole(domain) Line 211: except Exception: Line 212: # log any exception, but keep going Line 213: self.log.error("Error trying to check/update domain %s role",
Your are killing any sense of the SPM semantics and you can understand it i
no one is killing the SPM semantics - this behavior was the behavior till it was changed accidentally in the given patch I2ecf801d58b34c1c811e311e3779887a406af5f0 (as stated by the patch owner as well). You want to change the semantics that currently all the flows rely on, you are free to do so - first of all we should return the semantics to what they were before they were mistakenly changed either by deleting it or by ignoring a failure - that's what the discussion here should be about. Line 214: sdUUID, exc_info=True) Line 215: Line 216: @unsecured Line 217: def startSpm(self, prevID, prevLVER, maxHostID, expectedDomVersion=None):